Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing WITH_MMTK #79

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Removing WITH_MMTK #79

merged 1 commit into from
Dec 10, 2024

Conversation

udesou
Copy link

@udesou udesou commented Dec 10, 2024

Removing WITH_MMTK and deciding whether to build with MMTk based on MMTK_PLAN.

@udesou udesou mentioned this pull request Dec 10, 2024
Merged
@udesou udesou requested a review from qinsoon December 10, 2024 02:08
qinsoon
qinsoon approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably check with Julia guys and see if the change is fine. If they prefer the old way, we don't need to merge this PR.

@udesou
Copy link
Author

udesou commented Dec 10, 2024 •
edited
Loading

LGTM. Probably check with Julia guys and see if the change is fine. If they prefer the old way, we don't need to merge this PR.

I might cherry-pick this change and add it to the upstream-ready/immix PR. That way they'll review it immediately and give feedback (or not). If they decide it's not a good idea I'll rollback this PR.

@udesou udesou merged commit 6253fb9 into mmtk:dev Dec 10, 2024
4 checks passed
@udesou udesou mentioned this pull request Dec 11, 2024
Merged
udesou added a commit to mmtk/mmtk-julia that referenced this pull request Dec 11, 2024
@udesou
Removing WITH_MMTK (#202)
0a97e82 
Merge with mmtk/julia#79.
udesou added a commit to udesou/mmtk-julia that referenced this pull request Dec 12, 2024
@udesou
Removing WITH_MMTK (mmtk#202)
8844fa9 
Merge with mmtk/julia#79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udesou @qinsoon